[U-Boot] [PATCH 1/2] net: Sort Makefile labels

[Stefan Roese]

On Tuesday 10 February 2009, Michal Simek wrote:
> >>> +++ b/drivers/net/Makefile
> >>> @@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
> >>>  LIB    := $(obj)libnet.a
> >>>
> >>>  COBJS-$(CONFIG_DRIVER_3C589) += 3c589.o
> >>> +COBJS-$(CONFIG_PPC4xx_EMAC) += 4xx_enet.o
> >>>  COBJS-$(CONFIG_DRIVER_AX88180) += ax88180.o
> >>
> >> What makes you think that CONFIG_PPC4xx_EMAC has a good place between
> >> CONFIG_DRIVER_3C589 and CONFIG_DRIVER_AX88180?
>
> From my point of view make me more sense to rename 4xx_enec.c file to
> correspond with driver name. I mean if the config is CONFIG_PPC4xx_EMAC the
> filename should be ppc4xx_emac.c or in second case CONFIG_4XX_ENET for
> current 4xx_enet.c file. From these two choices I like the first one.

Yes, I also think it makes sense to rename this driver to "ppc4xx_emac.c". If 
nobody objects I'll send a patch doing this shortly.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================