[U-Boot] [PATCH 32/42] Blackfin: cm-bf533: new board port

[Wolfgang Denk]

Dear Mike Frysinger,

In message <1234246880-32438-33-git-send-email-vapier at gentoo.org> you wrote:
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> ---
>  MAINTAINERS                    |    5 +
>  MAKEALL                        |    1 +
>  Makefile                       |    4 +
>  board/cm-bf533/.gitignore      |    1 +
>  board/cm-bf533/Makefile        |   57 ++++++++
>  board/cm-bf533/cm-bf533.c      |   25 ++++
>  board/cm-bf533/config.mk       |   33 +++++
>  board/cm-bf533/flash-defines.h |   49 +++++++
>  board/cm-bf533/flash.c         |  283 ++++++++++++++++++++++++++++++++++++++++
>  board/cm-bf533/u-boot.lds.S    |  143 ++++++++++++++++++++
>  include/configs/cm-bf533.h     |  100 ++++++++++++++
>  11 files changed, 701 insertions(+), 0 deletions(-)
>  create mode 100644 board/cm-bf533/.gitignore
>  create mode 100644 board/cm-bf533/Makefile
>  create mode 100644 board/cm-bf533/cm-bf533.c
>  create mode 100644 board/cm-bf533/config.mk
>  create mode 100644 board/cm-bf533/flash-defines.h
>  create mode 100644 board/cm-bf533/flash.c
>  create mode 100644 board/cm-bf533/u-boot.lds.S
>  create mode 100644 include/configs/cm-bf533.h

General comment here and for the othe rpatches:

...
> --- a/Makefile
> +++ b/Makefile
> @@ -3292,6 +3292,9 @@ suzaku_config:	unconfig
>  BFIN_BOARDS = bf518f-ezbrd bf526-ezbrd bf527-ezkit bf533-ezkit bf533-stamp \
>  	bf537-stamp bf538f-ezkit bf548-ezkit bf561-ezkit
>  
> +# Bluetechnix tinyboards
> +BFIN_BOARDS += cm-bf533
> +
>  $(BFIN_BOARDS:%=%_config)	: unconfig
>  	@$(MKCONFIG) $(@:_config=) blackfin blackfin $(@:_config=)
>  	@$(MAKE) -s -B $(obj)include/autoconf.mk
> @@ -3453,6 +3456,7 @@ clean:
>  	       $(obj)board/netstar/{eeprom,crcek,crcit,*.srec,*.bin}	  \
>  	       $(obj)board/trab/trab_fkt   $(obj)board/voiceblue/eeprom   \
>  	       $(obj)board/{integratorap,integratorcp}/u-boot.lds	  \
> +	       $(obj)board/cm-bf533/u-boot.lds				  \
>  	       $(obj)board/bf5{18f,26,27,33,37,38f,48,61}-{ez{kit,brd},stamp}/u-boot.lds \
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

...
> diff --git a/board/cm-bf533/flash-defines.h b/board/cm-bf533/flash-defines.h
> new file mode 100644
> index 0000000..a5b590a
> --- /dev/null
> +++ b/board/cm-bf533/flash-defines.h
> @@ -0,0 +1,49 @@
...
> +#define MT_MANUFACT_CM_BF533 0x00890016	/* MT manuf. ID in D23..D16, D7..D0 */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...

> diff --git a/board/cm-bf533/flash.c b/board/cm-bf533/flash.c
> new file mode 100644
> index 0000000..f850840
> --- /dev/null
> +++ b/board/cm-bf533/flash.c
> @@ -0,0 +1,283 @@
...
> + * This file is based on BF533EzFlash.c originally written by Analog Devices, Inc.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...

> +		flash_info[0].start[i] = (CONFIG_SYS_FLASH_BASE + (i * FLASH_SECTOR_SIZE));
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> +	flash_info[0].size = CONFIG_SYS_FLASH_SIZE;
> +	flash_info[0].sector_count = FLASH_TOT_SECT;
> +	if (flash_info[0].flash_id == FLASH_UNKNOWN)
> +		printf("## Unknown FLASH on Bank 0\n");
> +	else {
> +		printf("Memory Map for the Flash\n");
> +		printf("0x%x - 0x%x Single Flash Chip\n", CONFIG_SYS_FLASH_BASE, CONFIG_SYS_FLASH_BASE + CONFIG_SYS_FLASH_SIZE);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Many, many lines are *way* too long.

Please fix gobally.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wenn Du ein' weise Antwort verlangst, Mußt Du vernünftig fragen.
                                                -- Goethe, Invektiven