[U-Boot] [PATCH 08/12] 83xx, kmeter: QE_ENET10 errata for Silicon Revision 2.1

[Kumar Gala]

On Feb 17, 2009, at 7:25 PM, Kim Phillips wrote:

> On Tue, 17 Feb 2009 09:54:51 +0100
> Heiko Schocher <hs at denx.de> wrote:
>
>> ppc_82xx-ld: NAND bootstrap too big
>> ppc_82xx-ld: NAND bootstrap too big
>> make[1]: *** [/home/hs/U-Boot-Patches/u-boot/nand_spl/u-boot-spl]  
>> Fehler 1
>> make: *** [nand_spl] Fehler 2
>> make: *** Warte auf noch nicht beendete Prozesse...
>> ppc_82xx-size: './u-boot': No such file
>> [hs at pollux u-boot]$
>>
>> I get this error just with actual u-boot.
>
> now that I've verified it, I see it too.  I bisected it:
>
> bced7ccefa08512c54a6d146658ff7dbc33d5dfe is first bad commit
> commit bced7ccefa08512c54a6d146658ff7dbc33d5dfe
> Author: Kumar Gala <galak at kernel.crashing.org>
> Date:   Fri Feb 6 08:08:06 2009 -0600
>
>    ppc: Fix roll over bug in flush_cache()
>
>    If we call flush_cache(0xfffff000, 0x1000) it would never
>    terminate the loop since end = 0xffffffff and we'd roll over
>    our counter from 0xfffffe0 to 0 (assuming a 32-byte cache line)
>
>    Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
>
> the extra checks this patch makes makes flush_cache() consume a mere  
> 16
> more bytes, which makes the SIMPC8313 build fail.
>
> I don't see an easy way out of this that satisfies everyone.  Ideas?
>
> Kim

what params is flush_cache() being called width on SIMC8313?

- k