[U-Boot] [PATCH v2] Create configuration option for restricted ns16550 functions

Wolfgang Denk wd at denx.de
Wed Feb 18 19:29:27 CET 2009


Dear Kim Phillips,

In message <20090218122152.7fbe1e25.kim.phillips at freescale.com> you wrote:
>
...
> this is my proposed fix:

In addition to the unnecessary overhead for the memory footprint there
are other problems with that patch:

> +#else
> +char NS16550_getc (NS16550_t com_port) { }
> +int NS16550_tstc (NS16550_t com_port) { }

If these functions are supposed to return "char" resp. "int", you will
get casty compiler warnings with an empty function body.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Any excuse will serve a tyrant."                             - Aesop


More information about the U-Boot mailing list