[U-Boot] [PATCH] Davinci I2C code cleanup

Wolfgang Denk wd at denx.de
Mon Feb 23 00:19:08 CET 2009


Dear ksi at koi8.net,

In message <Pine.LNX.4.64ksi.0902221504450.5270 at home-gw.koi8.net> you wrote:
> 
> > I am sure you could come up with an efficient *and* clean solution - if
> > you really wanted to try.
> 
> There is no way you can avoid that very same code repeated several times (7
> or so? didn't count them) -- that is how the driver works.

See above - I wrote "if you really wanted to try."   You don't.


> > The code as is is not acceptable and needs to be cleaned up.
> 
> Why not? What is wrong with that code?

I will not explain it again.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A person who is more than casually interested in computers should  be
well  schooled in machine language, since it is a fundamental part of
a computer.                                           -- Donald Knuth


More information about the U-Boot mailing list