[U-Boot] [PATCH v3] smc911x: split out useful defines/functions into local header

Mike Frysinger vapier at gentoo.org
Mon Feb 23 16:47:27 CET 2009


On Monday 23 February 2009 10:44:04 Guennadi Liakhovetski wrote:
> On Mon, 23 Feb 2009, Mike Frysinger wrote:
> > The smc911x driver has a lot of useful defines/functions which can be
> > used by pieces of code (such as example eeprom programmers).  Rather than
> > forcing each place to duplicate these defines/functions, split them out
> > of the smdc911x driver into a local header.
> >
> > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> > CC: Sascha Hauer <s.hauer at pengutronix.de>
> > CC: Guennadi Liakhovetski <lg at denx.de>
> > CC: Magnus Lilja <lilja.magnus at gmail.com>
> > CC: Ben Warren <biggerbadderben at gmail.com>
>
> Hm, sorry, have any of those other "pieces of code" been posted to the
> list?  I'd like to have a look at them to see what they need all those
> register definitions for.

it's already been posted in this thread (and Ben has merged it).  but to 
answer your question, external code doesnt generally need most of those 
register definitions.  they're moved because they belong in a header file and 
because it doesnt make sense to move just a few.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090223/8e3704bc/attachment.pgp 


More information about the U-Boot mailing list