[U-Boot] [PATCH v3] smc911x: split out useful defines/functions into local header

[Guennadi Liakhovetski]

On Mon, 23 Feb 2009, Mike Frysinger wrote:

> On Monday 23 February 2009 10:44:04 Guennadi Liakhovetski wrote:
> > On Mon, 23 Feb 2009, Mike Frysinger wrote:
> > > The smc911x driver has a lot of useful defines/functions which can be
> > > used by pieces of code (such as example eeprom programmers).  Rather than
> > > forcing each place to duplicate these defines/functions, split them out
> > > of the smdc911x driver into a local header.
> > >
> > > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> > > CC: Sascha Hauer <s.hauer at pengutronix.de>
> > > CC: Guennadi Liakhovetski <lg at denx.de>
> > > CC: Magnus Lilja <lilja.magnus at gmail.com>
> > > CC: Ben Warren <biggerbadderben at gmail.com>
> >
> > Hm, sorry, have any of those other "pieces of code" been posted to the
> > list?  I'd like to have a look at them to see what they need all those
> > register definitions for.
> 
> it's already been posted in this thread (and Ben has merged it).  but to 
> answer your question, external code doesnt generally need most of those 
> register definitions.  they're moved because they belong in a header file and 
> because it doesnt make sense to move just a few.

Ok, you mean these patches

[PATCH] smc911x_eeprom: new example app for managing newer SMC parts

Yep, agree, as long as some register definitions are used, it is better to 
move all to a header.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de