[U-Boot] [PATCH 5/8]: Use do_div from div64.h for vsprintf

Wolfgang Denk wd at denx.de
Mon Jul 20 23:59:22 CEST 2009


Dear Simon Kagstrom,

In message <20090720214252.B0B6E832E416 at gemini.denx.de> I wrote:
> Dear Simon Kagstrom,
> 
> In message <20090707155927.78e75333 at marrow.netinsight.se> you wrote:
> > Signed-off-by: Simon Kagstrom <simon.kagstrom at netinsight.net>
> > ---
> >  lib_generic/vsprintf.c |    7 +------
> >  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> Applied, thanks.

Sorry, I had to back out your patch. as it is causing compile problems:

-> ./MAKEALL voiceblue
Configuring for voiceblue board...
vsprintf.c: In function 'put_dec':
vsprintf.c:237: warning: comparison of distinct pointer types lacks a cast
vsprintf.c:237: warning: right shift count >= width of type
vsprintf.c:237: warning: passing argument 1 of '__div64_32' from incompatible pointer type
   text    data     bss     dec     hex filename
 142099    5196   23304  170599   29a67 ./u-boot

Please fix and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I think animal testing is a terrible idea; they get all  nervous  and
give the wrong answers.


More information about the U-Boot mailing list