[U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board

Wolfgang Denk wd at denx.de
Wed Jul 22 13:05:56 CEST 2009


Dear Matthias Fuchs,

In message <200907221214.25935.matthias.fuchs at esd.eu> you wrote:
> 
> > The braces should be indented by TABs.
> Can you please post a suggestion you you would like to this these
> lines indented. When I try to replace the spaces by TABs, the code
> looks very ugly and unreadable and I don't like that. 

So you want me to do the editing for you? May I send my invoice to
esd's address?

> So perhaps I missed what you mean and I have to reconfigure my emacs 
> autoindent mode to wd'mode.

I don't understand what's so difficult about it; just indent by TABs:

struct ppc4xx_config ppc4xx_config_val[] = {
	{
		"133",
		"CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
		{
			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00,
		}
	},
	{
		"266",
		"CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66",
		{
			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00,
		}
	},
	{
		"333",
		"CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111",
		{
			0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
			0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00,
		}
	},
};


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Half of the people in the world are below average.


More information about the U-Boot mailing list