[U-Boot] I wonder "---" in the patch file generated by the git-format-patch

Andy Fleming afleming at gmail.com
Tue Jun 2 17:07:15 CEST 2009


>
>
> So, I get patch. But, this patch's form is different with you said.
> First of all, the all comments is on the "---".
> But, you said all comments must belong below the "---" like this messages.
> :
> http://lists.denx.de/pipermail/u-boot/2009-June/053535.html
> It's different.
>
> What did I lose anything during the patching progress??
> Can you tell me what is wrong??



The comments you write in the commit message for your changes go above the
"---".  Those messages are meant to be included when the patch is applied,
to let everyone know why you made the changes you made in your patch.

However, if you want to say something in your email that isn't needed to
understand the patch's purpose and effect, then you put it below the "---",
and git will strip it out when the patch is applied.

So you might create several versions of your patch over time, due to review,
and on the final version.  Here's a totally fake example:

Fix a bug in the code that is here

This patch fixes the bug that has this effect.  Instead of doing the wrong
thing, we do the right thing instead.

Signed-off-by: My Name <myname at myplace.com>
---
Changes in this version of the patch are:
* Put these comments in the right place in the patch
* Properly added a Signed-off-by line
* Used better code style

Hey, friends, I made the changes to my patch that you suggested.

diff ---.....


More information about the U-Boot mailing list