[U-Boot] [PATCH] Fix OneNAND ipl to read 256KB

Wolfgang Denk wd at denx.de
Mon Mar 9 12:55:23 CET 2009


Dear Rohit Hagargundgi,

In message <200903091604.45906.h.rohit at samsung.com> you wrote:
> Currently OneNAND initial program loader (ipl) reads only block 0.
> However, u-boot image for apollon board is 195KB making the board
> unbootable with OneNAND.
> Fix ipl to read 256KB.

NAK.

The description is wrong:

The code was not changed to read 256 KB (fixed), but to read whetever
there is defined by the CONFIG_SYS_MONITOR_LEN definition.

Please change the commit messages accordingly.

Also, please split this into two separate patches: the first to
implement the feature (changes to onenand_ipl/onenand_read.c), and a
second one to fix the apollon board (changes to
include/configs/apollon.h).

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All a hacker needs is a tight PUSHJ, a loose pair of UUOs, and a warm
place to shift.


More information about the U-Boot mailing list