[U-Boot] [PATCH v6] Add support for the digsy MTC board.

Grzegorz Bernacki gjb at semihalf.com
Thu Mar 12 16:25:08 CET 2009


Wolfgang Denk wrote:
>> +	for (n = 0; n < 6 ; n++) {
>> +		addr = addr_of_eth_addr + n;
>> +		chip = EEPROM_ADDR + ((addr & 0x300)>>8);
>> +		i2c_read(chip, (addr & 0xFF), 1, (uchar *)&eth_addr[n], 1);
>> +	}
> 
> Can we not do this with a single i2c_read() call with length = 6 ?
> 

Yes we can, but it is safer this way in the case when ethernet address
spans across two chips. Rest of comments addressed in version 7 of the
patch which will be sent soon.

regards,
Grzesiek



More information about the U-Boot mailing list