[U-Boot] [PATCH] SF: always read 5 bytes for the idcode

Haavard Skinnemoen haavard.skinnemoen at atmel.com
Sun Mar 29 14:40:10 CEST 2009


Mike Frysinger wrote:
> Some SPI flash drivers like to have extended id information available
> (like the spansion flash), so rather than making it re-issue the ID cmd
> to get at the last 2 bytes, have the common code read 5 bytes rather than
> just 3.  This also matches the Linux behavior where it always reads 5 id
> bytes from all flashes.
> 
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> CC: Mingkai Hu <Mingkai.hu at freescale.com>
> CC: Haavard Skinnemoen <haavard.skinnemoen at atmel.com>

Yes, that's much better. But perhaps you should pass the last two bytes
to the debug() call a bit further down too?

I guess it's not essential though, so

Acked-by: Haavard Skinnemoen <haavard.skinnemoen at atmel.com>


More information about the U-Boot mailing list