[U-Boot] [PATCH] mem_mtest: fix error reporting, allow escape with ^C

Mike Frysinger vapier at gentoo.org
Fri Oct 2 01:57:50 CEST 2009


On Thursday 01 October 2009 19:52:27 Paul Gortmaker wrote:
>  		if (iteration_limit && iterations > iteration_limit) {
> -			printf("Tested %d iteration(s) without errors.\n",
> -				iterations-1);
> +			printf("Tested %d iteration(s) with %lu errors.\n",
> +				iterations-1, errs);
>  			return 0;

if you're showing the errs variable, then presumably it could possibly be non-
zero, so you wouldnt want to return 0 right ?
	return !!errs;

>  char *argv[]) incr = -incr;
>  	}
>  #endif
> -	return rcode;
> +	return 0;

i dont think you want to return 0 all the time here right ?
	return !!errs;

otherwise, the basic ^C handling is something that has annoyed me in the past, 
so acked-by for that :)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091001/c365517f/attachment.pgp 


More information about the U-Boot mailing list