[U-Boot] [PATCH] TI DaVinci DM646x: Adding initial support for DM6467 EVM

[Paulraj, Sandeep]

> > Patches will also be sent to enable EMAC, NAND and other features.
> >  Makefile                            |    3 +
> 
> Needs an addition to MAKEALL and optionally Maintainers

Ok I will add

> > diff --git a/include/configs/davinci_dm6467evm.h
> b/include/configs/davinci_dm6467evm.h
> > new file mode 100644
> > index 0000000..c23d533
> > --- /dev/null
> > +++ b/include/configs/davinci_dm6467evm.h
> > @@ -0,0 +1,131 @@
> > +/*
> > + * Copyright (C) 2009 Texas Instruments Incorporated -
> http://www.ti.com/
> 
> Above copyright did not have the http.
> You should be consistent.
> Add or remove, your choice.

Ok I will rectify

> > +
> > +/* SoC Configuration */
> > +#define CONFIG_ARM926EJS				/* arm926ejs CPU */
> > +#define CONFIG_SYS_TIMERBASE		0x01c21400	/* use timer 0 */
> 
> Is there a logical register #define you could use instead of the magic
> number?

I can include the hardware.h and get the value from there, but the way the hardware.h for DaVinci has evolved over the years, including it in the config will result in compilation failure.
I'll add this to my TODO list and send in a patch to clean up for all DaVinci SOC's the moment I get some free cycles.

> > +
> > +/* I2C Configuration */
> > +#define CONFIG_HARD_I2C
> > +#define CONFIG_DRIVER_DAVINCI_I2C
> > +#define CONFIG_SYS_I2C_SPEED		80000
> 
> This speed is unusual.

The same speed has been used with a slightly older version of U-boot and has worked fine

> davinci_sonata.h has a comment that it had a silicon bug with 100k
> Could the same comment be applied here ?

I don't believe so


> > +/* U-Boot general configuration */
> > +#undef	CONFIG_USE_IRQ				/* No IRQ/FIQ in U-Boot */
> 
> There is a TAB between #undef and CONFIG_USB_IRQ.
> Other undef's here use a space.

Ok will fix.
> 
> 
> > +#define CONFIG_BOOTDELAY	3
> > +#define CONFIG_BOOTFILE		"uImage"	/* Boot file name */
> > +#define CONFIG_SYS_PROMPT	"DM6467 EVM > "	/* Monitor Command Prompt
> */
> > +#define CONFIG_SYS_CBSIZE	1024		/* Console I/O Buffer Size  */
> > +#define CONFIG_SYS_PBSIZE		\
> > +		(CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
> > +#define CONFIG_SYS_MAXARGS		16
> > +#define CONFIG_VERSION_VARIABLE
> > +#define CONFIG_AUTO_COMPLETE
> > +#define CONFIG_SYS_HUSH_PARSER
> > +#define CONFIG_SYS_PROMPT_HUSH_PS2	"> "
> > +#define CONFIG_CMDLINE_EDITING
> > +#define CONFIG_SYS_LONGHELP
> > +#define CONFIG_CRC32_VERIFY
> > +#define CONFIG_MX_CYCLIC
> > +#define CONFIG_BOOTCOMMAND   		"source 0x82080000; dhcp; bootm"
> 
> 3 spaces at the end of CONFIG_BOOTCOMMAND can be removed.

Will fix

> Tom

Thanks,
Sandeep