[U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

Wolfgang Denk wd at denx.de
Sun Oct 4 17:44:06 CEST 2009


Dear Martha,

umm... your mail header still says "m marx".

In message <20091004102089.SM01140@[206.180.163.89]> you wrote:
> 
> I am planning to resubmit this patch very soon - by Tuesday perhaps.
> Considering there is some differences in the memory layout esp for the
> iopin struct (going from 32-bit to byte sizes)  I am not sure how I can
> get around the #defs you suggest.  Perhaps an entirely separate .c file
> for this part ??  

This depends on the situation. If the struct layout is absolutely
identical, just with different datatypes, we might use a #defined type
in the sruct. If not (which seems to be the case almost everywhere
where I looked), then we have to use at least different structs.

> Much of what you pointed to was copied over from the mpc5121ads ... so I
> didn't pay that much attention.  I will fix these too and also fix the
> 5121 code later.

Not paying much attention is always a bad thing which adds avoidable
efforts.

> When do you need it so I can give you enough time to look it over?

It depends. If you want to see this go in for the current release, we
should have clean and stable code in a week or two. Of head for the
next release, then ther eis no hurry at all.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unix: Some say the learning curve is steep,  but  you  only  have  to
climb it once.                                      - Karl Lehenbauer


More information about the U-Boot mailing list