[U-Boot] [PATCH] s5pc1xx: SMDKC100: fix compile warnings

Tom Tom.Rix at windriver.com
Sun Oct 18 15:48:28 CEST 2009


Minkyu Kang wrote:
> fix the following compile warnings
> warning: dereferencing type-punned pointer will break strict-aliasing rules
> 
> Signed-off-by: Minkyu Kang <mk7.kang at samsung.com>
> ---
>  drivers/serial/serial_s5pc1xx.c      |    2 +-
>  include/asm-arm/arch-s5pc1xx/clock.h |   88 +++++++++++++++++-----------------
>  include/asm-arm/arch-s5pc1xx/gpio.h  |   12 ++--
>  include/asm-arm/arch-s5pc1xx/pwm.h   |   36 +++++++-------
>  include/asm-arm/arch-s5pc1xx/uart.h  |   18 ++++----
>  include/linux/mtd/samsung_onenand.h  |   70 +++++++++++++-------------
>  6 files changed, 113 insertions(+), 113 deletions(-)
> 
> diff --git a/drivers/serial/serial_s5pc1xx.c b/drivers/serial/serial_s5pc1xx.c
> index 64c1dcc..68c06a9 100644
> --- a/drivers/serial/serial_s5pc1xx.c
> +++ b/drivers/serial/serial_s5pc1xx.c
> @@ -74,7 +74,7 @@ void serial_setbrg_dev(const int dev_index)
>  	val = pclk / baudrate;
>  
>  	writel(val / 16 - 1, &uart->ubrdiv);
> -	writel(udivslot[val % 16], &uart->udivslot);
> +	writew(udivslot[val % 16], &uart->udivslot);
>  }

If you are changing to using writew, the table udivslot should also 
change to match the type of udivslot, unsigned short.

Please submit a follow-on change for this.
Ack-ed.

Tom


More information about the U-Boot mailing list