[U-Boot] [PATCH 0/5] add TI da8xx support:

Tom Tom.Rix at windriver.com
Sun Oct 18 17:10:01 CEST 2009


Thompson, Nick (GE EntSol, Intelligent Platforms) wrote:
> Patches 1/5 and 2/5 both *still* contain small amounts of wrapping - why
> does outlook even consider that it's okay to mangle my e-mails??? - Please
> excuse the mess.
> 
> I can fix them, but I'm not going to send them again until people have
> had chance to comment on other aspects of the patch set.

It is likely your client is mangling other whitespace.

You need to track down why your email client is mangling line wrapping.
You may want to consider switching clients.
When posting patches I use git send-email + msmtp.

Do not get discouraged by this first review.

We will fight through the whitespace in the first round or two
and then hit the technical parts.  In general, it is good to have
your whitespace taken care before you post.  I recommend looking
at the u-boot coding style. http://www.denx.de/wiki/U-Boot/CodingStyle

I also run patches through the linux kernel's checkpatch.pl script.

For viewing whitespace, i use emacs+blank-mode.

Tom


> 
> Thanks,
> Nick.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot



More information about the U-Boot mailing list