[U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

[Mike Frysinger]

On Sunday 18 October 2009 17:32:15 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > Mike Frysinger wrote:
> > > > The env code is protected by the ENV_IS_EMBEDDED define, so
> > > > attempting to compile the code when this isn't defined is pointless. 
> > > > Now that the env headers have unified around CONFIG_ENV_IS_EMBEDDED,
> > > > convert the build system to only build the env objects when this is
> > > > enabled.  And now that the env code is conditionally compiled, we can
> > > > drop the source code checks.
> > > >
> > > > For people who want to extract the environment manually, add a new
> > > > option CONFIG_BUILD_ENVCRC that only enables the envcrc utility.
> > > >
> > > > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> > > > ---
> > > > v4
> > > > 	- rename config option to CONFIG_BUILD_ENVCRC
> > > >
> > > >  README                |    5 +++++
> > > >  common/Makefile       |    3 ---
> > > >  common/env_embedded.c |    7 -------
> > > >  include/common.h      |    5 +++++
> > > >  tools/Makefile        |    9 ++-------
> > > >  tools/envcrc.c        |   11 +----------
> > > >  6 files changed, 13 insertions(+), 27 deletions(-)
> > >
> > > Applied, thanks.
> 
> Arghhh...
> 
> This patch seems to break a *lot* of boards:
> 
> ...
> Configuring for mgsuvd board...
> ppc_6xx-ld: cannot find common/env_embedded.o
> make: *** [/work/wd/tmp-ppc/u-boot] Error 1
> 
> etc. etc.
> 
> Please fix, or should I rather revert the commit?

i'd prefer to fix.  my guess is these boards link in the .o all the time even 
when they dont have an embedded environment (which isnt a big deal -- the file 
would be 0 bytes in that case).

where can i get this "ppc_6xx" compiler ?
-mike