[U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed

[Mike Frysinger]

On Sunday 18 October 2009 17:32:15 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > Mike Frysinger wrote:
> > > > The env code is protected by the ENV_IS_EMBEDDED define, so
> > > > attempting to compile the code when this isn't defined is pointless. 
> > > > Now that the env headers have unified around CONFIG_ENV_IS_EMBEDDED,
> > > > convert the build system to only build the env objects when this is
> > > > enabled.  And now that the env code is conditionally compiled, we can
> > > > drop the source code checks.
> > > >
> > > > For people who want to extract the environment manually, add a new
> > > > option CONFIG_BUILD_ENVCRC that only enables the envcrc utility.
> > > >
> > > > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> > > > ---
> > > > v4
> > > > 	- rename config option to CONFIG_BUILD_ENVCRC
> > > >
> > > >  README                |    5 +++++
> > > >  common/Makefile       |    3 ---
> > > >  common/env_embedded.c |    7 -------
> > > >  include/common.h      |    5 +++++
> > > >  tools/Makefile        |    9 ++-------
> > > >  tools/envcrc.c        |   11 +----------
> > > >  6 files changed, 13 insertions(+), 27 deletions(-)
> > >
> > > Applied, thanks.
> 
> Arghhh...
> 
> This patch seems to break a *lot* of boards:

i'm attaching two patches here.  since we're past the merge window but before 
rc1, i dont know how invasive you want to get.

the first one restores env_embedded.o building for certain config options 
(even though it'll only produce a 0 byte file).  if you want to be cautious 
for this release, then i guess we can merge just this patch.

the second one attempts to clean up env_embedded.o in all linker scripts where 
the board would only end up with a 0 byte file.  obviously i cant test any of 
these since i dont have the hardware, but the logic seems straight forward.  
if you want to stay cautious, this would go into the next branch for start of 
next merge window.

or just merge the 2nd patch only and assume that people who dont test the rc1+ 
are dead boards anyways.  i got some build errors even after these fixes, but 
they seem unrelated to my env_embedded changes as they have to do with 
sections filling up & overflowing with my gcc-4.1.1 compiler.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-env-restore-limited-env_embedded-building.patch
Type: text/x-patch
Size: 1897 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091018/c09d17e6/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-env_embedded-remove-unused-code-from-linker-scripts.patch
Type: text/x-patch
Size: 34007 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091018/c09d17e6/attachment-0001.bin