[U-Boot] [PATCH 3/5] readline(): Add ability to modify a string buffer

Peter Tyser ptyser at xes-inc.com
Sat Oct 24 23:47:27 CEST 2009


Wolfgang Denk wrote:
> Dear Peter Tyser,
> 
> In message <1256259563-32725-3-git-send-email-ptyser at xes-inc.com> you wrote:
>> If the 'buf' parameter is a non-0-length string, its contents will be
>> edited.  Previously, the initial value of 'buf' was ignored and the
>> user entered its contents from scratch.
> 
> What is the purpose of this modification? Are you fixing a bug (which
> one?) or implementing an extension (which one) or what?

This change was necessary to add a new "editenv" command.  This change 
allows the readline() function to edit a string instead of just enter 
one from scratch.  In theory this feature could be used for other areas 
of U-Boot in the future, but at this point the only user of it would be 
the "editenv" command which I submitted a patch for.  If the 'editenv' 
patch is rejected, I don't mind this one being rejected too.

Best,
Peter


More information about the U-Boot mailing list