[U-Boot] [PATCH 4/8] OMAP3 Add usb device support

[Tom]

Gupta, Ajay Kumar wrote:
> Tom,
> 
>> From: Tom Rix <Tom.Rix <at> windriver.com>
>> Subject: [PATCH 4/8] OMAP3 Add usb device support
>> Newsgroups: gmane.comp.boot-loaders.u-boot
>> Date: 2009-09-28 16:37:25 GMT (4 weeks, 12 hours and 29 minutes ago)
>> This change adds the usb device support for musb.
>>
>> Omap3 platform support added at the same level as davinci.
>>
>> The interface for usbtty to use the musb device support was added.
>>
>> Verified on omap3 beagle, zoom1 and zoom2.
>>
>> Signed-off-by: Tom Rix <Tom.Rix <at> windriver.com>
>> ---
>>  drivers/serial/usbtty.h       |    2 +
>>  drivers/usb/musb/Makefile     |    2 +
>>  drivers/usb/musb/musb_core.c  |    8 +-
>>  drivers/usb/musb/musb_core.h  |   40 ++
>>  drivers/usb/musb/musb_debug.h |  205 +++++++++
>>  drivers/usb/musb/musb_udc.c   |  963
>> +++++++++++++++++++++++++++++++++++++++++
>>  drivers/usb/musb/omap3.c      |  129 ++++++
>>  drivers/usb/musb/omap3.h      |   48 ++
>>  include/usb.h                 |    3 +-
>>  include/usb/musb_udc.h        |   54 +++
>>  10 files changed, 1451 insertions(+), 3 deletions(-)
>>  create mode 100644 drivers/usb/musb/musb_debug.h
>>  create mode 100644 drivers/usb/musb/musb_udc.c
>>  create mode 100644 drivers/usb/musb/omap3.c
>>  create mode 100644 drivers/usb/musb/omap3.h
>>  create mode 100644 include/usb/musb_udc.h
>>
> 
> <snip>
> ..
> ..
> 
>> +int musb_platform_init(void)
>> +{
>> +       int ret = -1;
>> +
>> +       if (platform_needs_initialization) {
>> +              u32 stdby;
>> +
>> +              if (twl4030_usb_ulpi_init()) {
>> +                      serial_printf("ERROR: %s Could not initialize
>> PHY\n",
>> +                              __PRETTY_FUNCTION__);
>> +                      goto end;
>> +              }
> 
> OMAP3EVM uses ISP1504 phy and so twl4030 related init is not required.
> Can we move this within #ifdef like,
> 
> #ifndef CONFIG_OMAP3_EVM
> +              if (twl4030_usb_ulpi_init()) {
> ...
> ...
> #endif
> 
> 
> -Ajay

I will include this in the next revision.
Will the omap3_evm need to add its own PHY initialization
code ?