[U-Boot] [PATCH 6/8] OMAP3 beagle Add usbtty configuration

[Tom]

Gupta, Ajay Kumar wrote:
> Tom,
>> From: Tom Rix <Tom.Rix <at> windriver.com>
>> Subject: [PATCH 6/8] OMAP3 beagle Add usbtty configuration
>> Newsgroups: gmane.comp.boot-loaders.u-boot
>> Date: 2009-09-28 16:37:27 GMT (4 weeks, 12 hours and 41 minutes ago)
>>
>> The primary console of beagle is the serial header.
>>
>> A secondary console is to use the usbtty.  The user can set this
>> manually by doing
>>
>> setenv stdout usbtty; setenv stdin usbtty; setenv stderr usbtty
>> saveenv
>>
>> usbtty will be usable by accessing the /dev/ttyACM0 on a linux host.
>>
>> Signed-off-by: Tom Rix <Tom.Rix <at> windriver.com>
>> ---
>>  include/configs/omap3_beagle.h |   16 ++++++++++++++++
>>  1 files changed, 16 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/configs/omap3_beagle.h
>> b/include/configs/omap3_beagle.h
>> index 55eeb94..253cdba 100644
>> --- a/include/configs/omap3_beagle.h
>> +++ b/include/configs/omap3_beagle.h
>> @@ -98,6 +98,21 @@
>>  #define CONFIG_OMAP3_MMC		1
>>  #define CONFIG_DOS_PARTITION		1
>>
>> +/* USB */
>> +#define CONFIG_MUSB_UDC			1
>> +#define CONFIG_USB_OMAP3		1
>> +#define CONFIG_TWL4030_USB		1
>> +
>> +/* USB device configuration */
>> +#define CONFIG_USB_DEVICE		1
>> +#define CONFIG_USB_TTY			1
>> +#define CONFIG_SYS_CONSOLE_IS_IN_ENV	1
>> +/* Change these to suit your needs */
>> +#define CONFIG_USBD_VENDORID		0x0451
>> +#define CONFIG_USBD_PRODUCTID		0x5678
>> +#define CONFIG_USBD_MANUFACTURER	"Texas Instruments"
>> +#define CONFIG_USBD_PRODUCT_NAME	"Beagle"
>> +
> 
> We can either define CONFIG_MUSB_UDC or CONFIG_MUSB_HCD (host support), so I think it's better to move host and device specific definitions within
> CONFIG_MUSB_UDC or CONFIG_MUSB_HCD.
> 
> #ifdef CONFIG_USB_OMAP3
> 
> #ifdef  CONFIG_MUSB_HCD
> <here define all host specific definitions>
> #endif
> 
> #ifdef  CONFIG_MUSB_UDC
> <here define all device specific definitions>
> #endif
> 
> #endif /* CONFIG_USB_OMAP3 */
> 
> This change would make it easier to test Host or device functionalities.
> 
> -Ajay

I am not adding host support.
Tom