[U-Boot] [PATCH V3 3/4] add TI DA8xx support: Add new directory for da830evm board

[Wolfgang Denk]

Dear Nick Thompson,

In message <4AE5E002.9060204 at gefanuc.com> you wrote:
> Add new directory for da830evm board
> 
> Provides initial support for TI OMAP-L137/DA830 SoC devices on a Spectrum
> Digital EVM board. See http://www.spectrumdigital.com/
...
> diff --git a/board/davinci/common/misc.h b/board/davinci/common/misc.h
> index dc3cc41..d0fca65 100644
> --- a/board/davinci/common/misc.h
> +++ b/board/davinci/common/misc.h
> @@ -1,4 +1,5 @@
>  /*
> + * Copyright (C) 2009 Nick Thompson, GE Fanuc Ltd, <nick.thompson at gefanuc.com>
>   * Copyright (C) 2008 Lyrtech <www.lyrtech.com>

NAK.

We don't add Copyright entries just for adding a few lines of
#defines, only for really major code contributions. Your credit and
rights are sufficiently taken care of by the commit message and
Signed-off-by: lines.

...
> +int board_init(void)
> +{
> +
> +#ifndef CONFIG_USE_IRQ
> +	/*
> +	 * Mask all IRQs by clearing the global enable and setting
> +	 * the enable clear for all the 90 interrupts.
> +	 */
> +
> +	writel(0, INTC_GLB_EN);
> +
> +	writel(0, INTC_HINT_EN + 0x0);
> +	writel(0, INTC_HINT_EN + 0x4);
> +	writel(0, INTC_HINT_EN + 0x8);
> +
> +	writel(0xffffffff, INTC_EN_CLR0 + 0x0);
> +	writel(0xffffffff, INTC_EN_CLR0 + 0x4);
> +	writel(0xffffffff, INTC_EN_CLR0 + 0x8);

See previous review comment. Please use C structs here and in all
similar places.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Writing a book is like washing an elephant: there's no good place  to
begin  or  end,  and  it's  hard to keep track of what you've already
covered.