[U-Boot] [PATCH] ARM AT91 new board EB+CPUx9K2

[Wolfgang Denk]

Dear Jens Scharsig,

In message <4AE81893.30506 at bus-elektronik.de> you wrote:
>
> > Close, but please also get rid of this "((AT91PS_PIO) AT91C_BASE_PIOA)"
> > thing, especialy the cast is nasty. Declare a real pointer variable to
> > the respective data structure, and use that.
> > 
> 
> I, think
> 
> writel(AT91C_PA23_TXD2, AT91C_PIOA_OER);
> 
> is the most correct way. 

"most correct way" are big words. No, this is not "correct" at all.

The whole set of address / offset definitions in
include/asm-arm/arch-at91rm9200/AT91RM9200.h should be turned into a C
struct.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When all else fails, read the instructions.