[U-Boot] [PATCH] ARM S3C2410 add new board GEC2410

Peter Tyser ptyser at xes-inc.com
Fri Oct 30 04:18:17 CET 2009


> 2009/10/29 Hui.Tang <zetalabs at gmail.com>:
>> This patch add a S3C2410-based new board GEC2410.
>> Signed-off-by: Hui.Tang <zetalabs at gmail.com>
>> ---
>>  Makefile                              |    7 +
>>  board/gec/gec2410/Makefile            |   51 ++++
>>  board/gec/gec2410/config.mk           |   32 +++
>>  board/gec/gec2410/flash.c             |  433 +++++++++++++++++++++++++++++++++
>>  board/gec/gec2410/gec2410.c           |  147 +++++++++++
>>  board/gec/gec2410/lowlevel_init.S     |  169 +++++++++++++
>>  board/gec/gec2410/u-boot-nand.lds     |   61 +++++
>>  cpu/arm920t/s3c24x0/timer.c           |    1 +
>>  cpu/arm920t/start.S                   |   36 +++
>>  drivers/mtd/nand/s3c2410_nand.c       |   46 +++-
>>  drivers/net/cs8900.c                  |    2 +-
>>  include/configs/gec2410.h             |  288 ++++++++++++++++++++++
>>  nand_spl/board/gec/gec2410/Makefile   |  102 ++++++++
>>  nand_spl/board/gec/gec2410/config.mk  |   40 +++
>>  nand_spl/board/gec/gec2410/u-boot.lds |   60 +++++
>>  15 files changed, 1469 insertions(+), 6 deletions(-)
>>  create mode 100644 board/gec/gec2410/Makefile
>>  create mode 100644 board/gec/gec2410/config.mk
>>  create mode 100644 board/gec/gec2410/flash.c
>>  create mode 100644 board/gec/gec2410/gec2410.c
>>  create mode 100644 board/gec/gec2410/lowlevel_init.S
>>  create mode 100644 board/gec/gec2410/u-boot-nand.lds
>>  create mode 100644 include/configs/gec2410.h
>>  create mode 100644 nand_spl/board/gec/gec2410/Makefile
>>  create mode 100644 nand_spl/board/gec/gec2410/config.mk
>>  create mode 100644 nand_spl/board/gec/gec2410/u-boot.lds
>>
> 
> thanks for your patch.
> 
> First, please do checkpatch and fix the style problems.
> (total: 20 errors, 106 warnings, 1614 lines checked)
> Second, please separate your patch (board, cpu, soc, spl, etc..)
> Third, please fix the copyright. I couldn't find your name.
> And then, we will review your patch.

You should also add an entry to MAINTAINERS and MAKEALL when you 
resubmit your board support patch.

Best,
Peter


More information about the U-Boot mailing list