[U-Boot] [RFC][PATCH v2 17/19] arm cp15: setup mmu and enable dcache

[Heiko Schocher]

Hello Ben,

Ben Gardiner wrote:
> On Tue, Aug 3, 2010 at 6:16 AM, Heiko Schocher <hs at denx.de> wrote:
>> This has been tested on at91sam9263 and STN8815.
>> Again, I didn't check if it has bad effects
>> on non-arm926 cores.
>>
>> Initially I had a "done" bit to only set up page tables
>> at the beginning. However, since the aligmnent requirement
>> was for the whole object file, this extra integer tool 16kB
>> in BSS, so I chose to remove it.
>>
>> Also, note not all boards use PHYS_SDRAM, but it looks like
>> it's the most used name (more than CONFIG_SYS_DRAM_BASE for
>> example).
>>
>> rebased for full arm relocation from Heiko Schocher <hs at denx.de>
>>
>> Signed-off-by: Alessandro Rubini <rubini at gnudd.com>
>> Signed-off-by: Heiko Schocher <hs at denx.de>
> 
> This v2 of the patch makes 18/19 fail to apply:
> 
> Applying: arm cp15: setup mmu and enable dcache
> Applying: beagle, cache: activate cache command
> /media/unixdata/src/u-boot/uboot-nand/nand_and_omapl1/.git/rebase-apply/patch:15:
> new blank line at EOF.
> +
> error: patch failed: arch/arm/lib/cache-cp15.c:25
> error: arch/arm/lib/cache-cp15.c: patch does not apply
> Patch failed at 0018 beagle, cache: activate cache command

Sorry, missed that. I send this patch ASAP.

> It looks to me like the introduction of  CACHE_SETUP here in v2 needs
> to be propagated to the extraction of the mmu setup to
> dram_bank_mmu_setup made in 18/19. I tried to merge the changes this
> way and when I finally got all 19 applied the board did not come up --

Which board?

> I'm sorry I don't have more details than that, it is serial-console
> connected only and there is no jtag debugger setup here (yet).

I think you must debug this ...

> I'm not sure if the board was dead because of my failure to merge the
> patch that did not apply cleanly or if it is because of the
> CONFIG_SYS_INIT_SP_ADDR 'Fix this' in the da850evm.h -- I haven't
> changed the value from 'CONFIG_SYS_SDRAM_BASE + 0x1000 -+
> CONFIG_SYS_GBL_DATA_SIZE' introduced in 15/19.

Ah, so your board is the da850evm, right? This should be no problem,
as dram is setup at this point, but we should find another (not dram)
area, which we can use for an initial stack.

> I would be happy to test the next version of the series but it would
> be much easier to do so if there was a branch in u-boot-testing as
> suggested by Detlev.

Ok.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany