[U-Boot] [PATCH] davinci: Rewrite timer.c to use tbl/tbu emulation variables in gd

Nick Thompson nick.thompson at ge.com
Thu Dec 2 15:37:49 CET 2010


On 02/12/10 14:18, Ben Gardiner wrote:
> Hi Nick,
> 
> On Thu, Dec 2, 2010 at 8:57 AM, Nick Thompson <nick.thompson at ge.com> wrote:
>> This change allows the davinci timer functions to be used before
>> relocation since it avoids using static variables prior to BSS being
>> made available.

>> Signed-off-by: Nick Thompson <nick.thompson at ge.com>
>> ---
>> This patch relies on http://patchwork.ozlabs.org/patch/73758/ which has not been
>> accepted yet. I have made a comment on it, suggesting that it should be changed:
>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/90040/focus=90162

> 
> Applies cleanly to v2010.12-rc2 on top of
> http://patchwork.ozlabs.org/patch/73758/
> 
> Tested on da850evm w/o any config changes. This fixes the freeze on
> boot: 10/10 times.
> 
> You're awesome, Nick!
> 
> Tested-by: Ben Gardiner <bengardiner at nanometrics.ca>

I thought it sounded like the problem you where having. Glad it helps.

Thanks for the Tested-by.

>> +       endtime = ((unsigned long long )usec * gd->timer_rate_hz) / 1000000UL;
> 
> just one minor checkpatch.pl warning; should be (unsigned long long)
> -- no space before ')'

Good spot. I've fixed that locally and will submit a v2 if the depending
patch finds favour - Alternative approaches have been suggested, this one
is *my* short-term favourite.

Thanks,
Nick.


More information about the U-Boot mailing list