[U-Boot] [PATCH v2] tsec: Revert to setting TBICR_ANEG_ENABLE by default for SGMII

Kumar Gala galak at kernel.crashing.org
Mon Dec 13 16:29:48 CET 2010


On Dec 9, 2010, at 9:52 AM, Kumar Gala wrote:

> The following commit:
> 
> commit 46e91674fb4b6d06c6a4984c0b5ac7d9a16923f4
> Author: Peter Tyser <ptyser at xes-inc.com>
> Date:   Tue Nov 3 17:52:07 2009 -0600
> 
>    tsec: Force TBI PHY to 1000Mbps full duplex in SGMII mode
> 
> Removed setting Auto-Neg by default, however this is believed to be
> proper default configuration for initialization of the TBI interface.
> 
> Instead we explicitly set CONFIG_TSEC_TBICR_SETTINGS for the
> XPedite5370 & XPedite5500 boards that use a Broadcomm PHY which require
> Auto-Neg to be disabled to function properly.
> 
> This addresses a breakage on the P2020 DS & MPC8572 DS boards when used
> with an SGMII riser card.  We also remove setting
> CONFIG_TSEC_TBICR_SETTINGS on the P1_P2_RDB family of boards as now the
> default setting is sufficient for them.
> 
> Additionally, we clean up the code a bit to remove an unnecessary second
> define.
> 
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> Acked-by: Peter Tyser <ptyser at xes-inc.com>
> Tested-by: Peter Tyser <ptyser at xes-inc.com>
> ---
> * Added comments per Peter T's request
> 
> drivers/net/tsec.c            |    9 ++++-----
> include/configs/P1_P2_RDB.h   |    8 --------
> include/configs/xpedite537x.h |   10 ++++++++++
> include/configs/xpedite550x.h |   10 ++++++++++
> 4 files changed, 24 insertions(+), 13 deletions(-)

applied to 85xx

- k


More information about the U-Boot mailing list