[U-Boot] [PATCH 1/1] armv7: start.S: code cleanup

Jason Liu liu.h.jason at gmail.com
Mon Dec 20 08:05:58 CET 2010


Hi, Albert,

2010/12/20 Albert ARIBAUD <albert.aribaud at free.fr>:
> Hi Jason,
>
> Le 20/12/2010 07:14, Jason Liu a écrit :
>> Remove the useless code from start.S
>>
>> Signed-off-by: Jason Liu<r64343 at freescale.com>
>> ---
>>   arch/arm/cpu/armv7/start.S |    2 --
>>   1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S
>> index 684f2d2..cb4f92f 100644
>> --- a/arch/arm/cpu/armv7/start.S
>> +++ b/arch/arm/cpu/armv7/start.S
>> @@ -171,7 +171,6 @@ stack_setup:
>>       beq     clear_bss               /* skip relocation */
>>   #endif
>>       mov     r1, r6                  /* r1<- scratch for copy_loop */
>> -     ldr     r2, _TEXT_BASE
>>       ldr     r3, _bss_start_ofs
>>       add     r2, r0, r3              /* r2<- source end address          */
>>
>> @@ -224,7 +223,6 @@ fixnext:
>>   clear_bss:
>>       ldr     r0, _bss_start_ofs
>>       ldr     r1, _bss_end_ofs
>> -     ldr     r3, _TEXT_BASE          /* Text base */
>>       mov     r4, r6                  /* reloc addr */
>>       add     r0, r0, r4
>>       add     r1, r1, r4
>
> These changes are not a bug fix; they will be deferred until after the
> upcoming release --

OK, agree.

and then, I would welcome a single patchset with
> changes to all ARM cpus where this should be done. Can you do this?

I will do it if it need take the change for other ARM cpus than ARMV7
with one single patch.

BR,
Jason


> Thanks in advance.
>
> Amicalement,
> --
> Albert.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>


More information about the U-Boot mailing list