[U-Boot] [PATCH] AT91: Added support for taskit Stamp9G20 and PortuxG20

[Wolfgang Denk]

Dear Achim Ehrlich,

In message <4B827909.3010804 at taskit.de> you wrote:
> 
> >> +#ifdef CONFIG_RESET_PHY_R
> >> +void reset_phy(void)
> >> +{
> >> +#ifdef CONFIG_MACB
> > 
> > 
> > CONFIG_MACB seems to be an undocumented variable. What is it supposed
> > to do?
> 
> It switches on the pin initialization for the Ethernet MAC.
> Actually, i just copied this part from the AT91SAM9260ek board code.

If you uuse it, please add a short note to the READMe, then.

But do you really need this? What would reset_phy() do if this
variable was not set?

> >> diff --git a/include/configs/stamp9G20.h b/include/configs/stamp9G20.h
> >> new file mode 100644
> >> index 0000000..5008554
> >> --- /dev/null
> >> +++ b/include/configs/stamp9G20.h
> > ...
> >> +/* ARM asynchronous clock */
> >> +#define AT91_MAIN_CLOCK		18432000	/* 18.432 MHz crystal */
> > 
> > This should be changed into a CONFIG_SYS_ (globally).
> >
> 
> Do you mean, I should change that for all AT91-Boards in u-boot?

Such a change would indeed make sense to me (it should be done
separately and indenpendent from your patch, probably before adding
your code).

> How or who is going to test that?

We can compare the binary images for all AT91 builds - except for the
time stamps they should be unaffected by this change. And we can
actually test the images on a few boards.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Use the Force, Luke.