[U-Boot] [PATCH] orion5x: edminiv2: add libata support

[Wolfgang Denk]

Dear Albert ARIBAUD,

In message <4C2BC6CB.1070802 at free.fr> you wrote:
> 
> > Incorrect multiline comment style.
> 
> Will this be ok?

Yes.

> >> -#if defined(__PPC__) || defined(CONFIG_PXA_PCMCIA) || defined(CONFIG_SH)
> >> +#if defined(__PPC__) || defined(CONFIG_PXA_PCMCIA) || defined(CONFIG_SH) \
> >> +	|| defined(__ARM__)
> >
> > Please do not add to this mess of tests, but introduce a single
> > feature-specific #define instead.
>
> Will do. Would CONFIG_IDE_USE_INSW_OUTSW do? Basically, that's what the >
> test is for: either use outsw()/insw() or use outw()/inw() within a loop.

Or CONFIG_IDE_SWAP_IO or similar?

> Note that this change does not relate per se to my patch and requires
> addition of this #define to a lot of config header files. Wouldn't it be
> better if I submitted it as an independent atomic patch?

Indeed this should be then a part 1/N patch in your series.

> I'll put them in two separate patches, one for fixing typos and one for >
> adding the CONFIG_SKIP_LOWLEVEL_INIT comments and line.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
They weren't that important. They were merely at the top. The  people
who  really  run organizations are usually found several levels down,
where it's still possible to get things done.
                                      - Terry Pratchett, _Small Gods_