[U-Boot] [PATCH 07/28] SPEAr : macb driver support added for spear310 and spear320

[Wolfgang Denk]

Dear Vipin KUMAR,

In message <1279084204-3263-8-git-send-email-vipin.kumar at st.com> you wrote:
> From: Vipin KUMAR <vipin.kumar at st.com>
> 
> SPEAr310 and SPEAr320 SoCs have an extra ethernet controller. The
> driver for this device is already supported by u-boot, so configuring
> board configuration file and defining base addresses etc to make use
> of the common driver
> 
> Signed-off-by: Vipin Kumar <vipin.kumar at st.com>
> ---
>  arch/arm/include/asm/arch-spear/clk.h      |   27 +++++++++++++++++++++++++++
>  arch/arm/include/asm/arch-spear/hardware.h |    7 +++++++
>  board/spear/spear310/spear310.c            |   25 ++++++++++++++++++++++---
>  board/spear/spear320/spear320.c            |   12 +++++++++---
>  include/configs/spear3xx.h                 |   13 +++++++++++++
>  5 files changed, 78 insertions(+), 6 deletions(-)
>  create mode 100644 arch/arm/include/asm/arch-spear/clk.h
...
> +#if defined(CONFIG_MACB)
> +	if (macb_eth_initialize(0, (void *)CONFIG_SYS_MACB0_BASE,
> +				CONFIG_MACB0_PHY) < 0)
> +		ret += -1;
> +
> +	if (macb_eth_initialize(1, (void *)CONFIG_SYS_MACB1_BASE,
> +				CONFIG_MACB1_PHY) < 0)
> +		ret += -1;
> +
> +	if (macb_eth_initialize(2, (void *)CONFIG_SYS_MACB2_BASE,
> +				CONFIG_MACB2_PHY) < 0)
> +		ret += -1;
> +
> +	if (macb_eth_initialize(3, (void *)CONFIG_SYS_MACB3_BASE,
> +				CONFIG_MACB3_PHY) < 0)
> +		ret += -1;

We need braces for multiline statements.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Infidels in all ages have battled for the rights of man, and have at
all times been the fearless advocates of liberty and justice."
- Robert Green Ingersoll