[U-Boot] [PATCH 15/28] SPEAr : spear1300 SoC support added

[Vipin KUMAR]

On 7/16/2010 3:34 AM, Wolfgang Denk wrote:
> Dear Vipin KUMAR,
> 

Dear Wolfgang,

> In message <1279084204-3263-16-git-send-email-vipin.kumar at st.com> you wrote:
>> From: Vipin KUMAR <vipin.kumar at st.com>
>>
>> SPEAr1300 SoC support contains basic spear1300 support along with the
>> usage of following drivers
> 
> Are you here adding support for a SoC or for a board???  Looks more
> like board support to me...
> 

Yes, it is a board support. I would change this comment here

> ...
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -2107,6 +2107,12 @@ spear600_usbtty_config \
>>  spear600_usbtty_nand_config :	unconfig
>>  	@$(MKCONFIG) -n $@ -t $@ spear6xx_evb arm arm926ejs $(@:_config=) spear spear
>>  
>> +spear1300_config \
>> +spear1300_nand_config \
>> +spear1300_usbtty_config \
>> +spear1300_usbtty_nand_config :	unconfig
>> +	@$(MKCONFIG) -n $@ -t $(@:_config=) spear13xx_evb arm arm_cortexa8 spear1300 spear spear13xx
> 
> NAK.
> 
> Please use boards.cfg instead.
> 

OK.

> 
> ...
>> +int misc_init_r(void)
>> +{
>> +	setenv("verify", "n");
> 
> NAK.
> 
> Please don't mess with things a user might want to do differently.
> 
> You can add this as default settingin your environment, but please
> allow the user to dicede otherwise.
> 

OK. I would add this in default environments in patch-set v2

> 
> 

Thanks for your valuable inputs. I would incorporate these and send a patch-set v2

Thanks and Regards
Vipin

> Best regards,
> 
> Wolfgang Denk
>