[U-Boot] [PATCH] Change the configuration for the STx GP3-SSA board in order to support FDT parsing and passing.

[Wolfgang Denk]

Dear Bradley Hughes,

your Subject: is WAY too long - please restict to some 60 characters
or so.

In message <AANLkTimM0NENrBZo9seY6OlLNmU_fz3tv9LWZeG8ykRN at mail.gmail.com> you wrote:
> Change the configuration for the STx GP3-SSA board in order to support
>  FDT parsing and passing.

...and please don't repeat the same in the commit message.
 
...
> diff --git a/board/stx/stxssa/stxssa.c b/board/stx/stxssa/stxssa.c
> index 0b2584c..9cd2c62 100644
> --- a/board/stx/stxssa/stxssa.c
> +++ b/board/stx/stxssa/stxssa.c
> @@ -40,6 +40,8 @@
>  #include <spd_sdram.h>
>  #include <miiphy.h>
>  #include <netdev.h>
> +#include <libfdt.h>
> +#include <fdt_support.h>
> 
>  long int fixed_sdram (void);
> 
> @@ -407,3 +409,11 @@ int board_eth_init(bd_t *bis)
>  	cpu_eth_init(bis);	/* Initialize TSECs first */
>  	return pci_eth_init(bis);
>  }
> +
> +#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
> +void ft_board_setup(void *blob, bd_t *bd)
> +{
> +        ft_cpu_setup(blob, bd);
> +}
> +#endif /* defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP) */
> +

Please don't add trailing empty lines.

> diff --git a/include/configs/stxssa.h b/include/configs/stxssa.h
> index 363f7b4..d7adee9 100644
> --- a/include/configs/stxssa.h
> +++ b/include/configs/stxssa.h
...
> -#define CONFIG_MPC8560		1
> +#define CONFIG_MPC8555		1

Hm... is this correct? The board I have here actually seems to use a
8541E ?


> @@ -419,6 +426,20 @@
>  #define CONFIG_ETH2ADDR  00:e0:0c:07:9b:8c
>  #endif
> 
> +
> +
> +/*

Please max. 2 blank lines.

> + * Configuration options for EEPROM or FLASH Setup
> + */
> +#define CONFIG_SERVERIP		10.10.0.150
> +#define CONFIG_IPADDR		10.10.0.95
> +#define CONFIG_GATEWAYIP	10.10.0.1
> +#define CONFIG_NETMASK		255.255.255.0
> +#define CONFIG_HOSTNAME		STX_SSA
> +#define CONFIG_ROOTPATH		/opt/ppc/ppc_85xx
> +#define CONFIG_BOOTFILE 	stxssa/uImage
> +#define CONFIG_FDTFILE		stxssa/stxssa.fdt

NAK. We do not allow network configuration in the board config file;
it may be correct for you, but it is wrong for all other users.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The X11 source code style is ATROCIOUS and should not be used  as  a
model."                                                   - Doug Gwyn