[U-Boot] [PATCH 03/10] 83xx/85xx/86xx: LBC register cleanup

Peter Tyser ptyser at xes-inc.com
Tue Jun 1 17:26:25 CEST 2010


Hi Becky,

On Fri, 2010-05-28 at 16:45 -0500, Becky Bruce wrote:
> --- a/arch/powerpc/include/asm/config.h
> +++ b/arch/powerpc/include/asm/config.h
> @@ -76,4 +76,7 @@
>  /* Relocation to SDRAM works on all PPC boards */
>  #define CONFIG_RELOC_FIXUP_WORKS
>  
> +/* Currently all plats have a local bus controller */
> +#define CONFIG_FSL_LBC
> + 

The above doesn't appear to break anything, but it seems a bit odd to
define CONFIG_FSL_LBC for all PPC boards.  Would it be possible to only
define CONFIG_FSL_LBC and CONFIG_FSL_ELBC in config.h based on some
CONFIG_MPCyyy conditionals and then get rid of patch 1/10 in this
series?

If not, maybe CONFIG_FSL_LBC should be protected by a "#if
defined(CONFIG_MPC83xx) || defined(CONFIG_MPC85xx...", or moved down
into board config files similar to CONFIG_FSL_ELBC to prevent it from
appearing for every PPC board.

Best,
Peter



More information about the U-Boot mailing list