[U-Boot] [PATCH] Add support for LPC2468 from NXP

[Remco Poelstra]

Hi,

On 02-06-10 12:03, Wolfgang Denk wrote:
>
>> diff --git a/arch/arm/cpu/arm720t/lpc24xx/iap_entry.S b/arch/arm/cpu/arm720t/lpc24xx/iap_entry.S
>> new file mode 100644
>> index 0000000..c31d519
>> --- /dev/null
>> +++ b/arch/arm/cpu/arm720t/lpc24xx/iap_entry.S
>> @@ -0,0 +1,7 @@
>> +IAP_ADDRESS:	.word	0x7FFFFFF1
>> +
>> +.globl iap_entry
>> +iap_entry:
>> +	ldr	r2, IAP_ADDRESS
>> +	bx	r2
>> +	mov	pc, lr
>>      
> Verbatim copy of arch/arm/cpu/arm720t/lpc2292/iap_entry.S - please
> unify.
>
>    

Looking at other architectures for inspiration to solve the above 
problem, I find that it's common practice to not-share common code 
between SOC's. Is there a reason for that?
Furthermore I see the same problems with some code using direct register 
access and other almost identical code using C-structure based access. 
Maybe these SOC's are in the same process of getting converted to 
C-structures?
Main point: What do you want me to do? I fixed the other minor comments, 
so I can send a new patch if you want.


Regards,

Remco Poelstra