[U-Boot] [PATCH] add support for EMK TOP7000 CPU module

Reinhard Meyer (-VC) reinhard.meyer at emk-elektronik.de
Sun Jun 6 13:52:07 CEST 2010


Wolfgang Denk schrieb:
> Dear "Reinhard Meyer (-VC)",
> 
> In message <4C0B85D8.4070508 at emk-elektronik.de> you wrote:
>> is this patch going to be accepted, or is someone insisting that only
>> my port shall return the number of controllers initialized?
> 
> I don't understand what you mean by "only my port". Ben's comment that
> board_eth_init() is supposed to retrurn the number of  successfully
> initialized controllers has been standard policy for a pretty long
> time, and many boards do so.
> 
> Eventually the boards you compared against are older ones, and have
> not been maintained well, so they misbehave in this regard?
> 
> Best regards,
> 
> Wolfgang Denk
> 

Hello Wolfgang,

Is that documented somewhere? I see that the calling function in net.c
does NOT care about any positive interger result. Will it care sometime
in the future? :)

The second problem is that I cannot seem to undo my previous commit in my
tree, so any changes I do to my source would come out as a second patch.
Would that be accepted?

Or do you know what must be done that GIT will issue a new patch with the
current and the new changes in one patch?

I generate the patches by
<after editing>:
git commit -m <message>
git format-patch origin

what to do to return to <after editing>, do new edits and generate a new,
single patch?

Best Regards, Reinhard



More information about the U-Boot mailing list