[U-Boot] [PATCH] MPC512x: workaround data corruption for unaligned local bus accesses

Detlev Zundel dzu at denx.de
Tue Jun 29 13:49:11 CEST 2010


Hi Wolfgang,

> Commit 460c2ce3 "MPC5200: workaround data corruption for unaligned
> local bus accesses" fixed the problem for MPC5200 only, but MPC512x is
> affected as well, so apply the same fix here, too.
>
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> Cc: Detlev Zundel <dzu at denx.de>
> Cc: Anatolij Gustschin <agust at denx.de>
> ---
>  arch/powerpc/cpu/mpc5xxx/Makefile                  |    5 -----
>  arch/powerpc/lib/Makefile                          |   16 ++++++++++++----
>  arch/powerpc/{cpu/mpc5xxx => lib}/memcpy_mpc5200.c |    0
>  3 files changed, 12 insertions(+), 9 deletions(-)
>  rename arch/powerpc/{cpu/mpc5xxx => lib}/memcpy_mpc5200.c (100%)

Acked-by: Detlev Zundel <dzu at denx.de>

The only thing I wonder is the filename 'memcpy_mpc5200.c' as the code
doesn't really have any 5200 specifics in it.  What about
'memcpy_align32wrap' or something likew that to express the more general
nature of the code?

If one thinks further along this line, why not move the wrapper to lib/? 

Cheers
  Detlev

-- 
LISP is the most powerful programming language, and if you want an inter-
preter, LISP is the best.  None of the other languages come anywhere near
LISP in their power.  The most exciting things about LISP are read, eval,
and print.  If you look at other languages,  they have no equivalent for
any of those.                             -- Richard Stallman
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de


More information about the U-Boot mailing list