[U-Boot] [PATCH] TQM85xx: Fix bug introduced by 83xx/85xx/86xx: LBC register cleanup

[Becky Bruce]

On Nov 11, 2010, at 4:30 PM, Wolfgang Denk wrote:

> Dear Becky Bruce,
> 
> In message <1289496785-9243-1-git-send-email-beckyb at kernel.crashing.org> you wrote:
>> The size of the other bank needed to be added to the br0 setting;
>> this got dropped in the LBC cleanup.
>> 
>> Signed-off-by: Becky Bruce <beckyb at kernel.crashing.org>
>> ---
>> This has been neither built or tested, as TQM8555 doesn't seem to build on the
>> head of this tree, and I don't have a board to test on.
> 
> It build just fine for me... What exactly are your problems? [And
> which tool chain are you using?]

Actually, that looks to be spurious - I thought i was building from a clean tree but turns out it wasn't.  When I do a clean and then a build it works fine.  This is what happens when you write code from your car.....

> 
> 
> Your patch indeed fixes the problem (and I'm a bit angry with myself
> that I didn't see this problem myself.)

Well, that's two of us, because I'm a bit angry at myself for causing it :)

Cheers,
B

> 
> Thanks a lot!
> 
> 
> Tested on TQM8555.
> 
> Tested-by: Wolfgang Denk <wd at denx.de>
> Acked-by: Wolfgang Denk <wd at denx.de>
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> We are all agreed that your  theory  is  crazy.  The  question  which
> divides  us  is  whether it is crazy enough to have a chance of being
> correct. My own feeling is that it is not crazy enough.  - Niels Bohr