[U-Boot] [PATCH v2] drivers/net/fec_mxc.c: write mac address ininit

[Jason Liu]

Hi, John

2010/10/22 John Rigby <jcrigby at gmail.com>:
> For current mx51 support in u-boot where we have no fuse support the
> patch is useful.  I don't recall what the general policy is in u-boot
> for env vs eeprom mac addresses but I do remember discussions about
> it.

Geting mac address from FUSE is the right way for mx51 and it's not
difficult to add FUSE read function due to the FUSE read is simple as
the memory read. I have seen that Shawn has posted the patches to
Linaro-uboot git there.

>
> On Tue, Oct 19, 2010 at 11:21 PM, Liu Hui-R64343 <r64343 at freescale.com> wrote:
>> Hi, John & Wolfgang,
>>
>>> -----Original Message-----
>>> From: u-boot-bounces at lists.denx.de
>> [mailto:u-boot-bounces at lists.denx.de]
>>> On Behalf Of Wolfgang Denk
>>> Sent: Wednesday, October 20, 2010 5:28 AM
>>> To: John Rigby
>>> Cc: u-boot at lists.denx.de; Ben Warren
>>> Subject: Re: [U-Boot] [PATCH v2] drivers/net/fec_mxc.c: write mac
>> address
>>> ininit
>>>
>>> Dear John Rigby,
>>>
>>> In message <1287001868-22244-1-git-send-email-john.rigby at linaro.org>
>> you
>>> wrote:
>>> > Call fec_set_hwaddr in init routine to setup MAC address so when
>>> ethaddr is set
>>> > late via setenv the change will propagate to the hw.
>>> >
>>> > Signed-off-by: John Rigby <john.rigby at linaro.org>
>>> > CC: Ben Warren <biggerbadderben at gmail.com>
>>> > ---
>>> > v2 - add blank line as requested
>>> >      better commit message
>>> >      added CC
>>> >  drivers/net/fec_mxc.c |    3 +++
>>> >  1 files changed, 3 insertions(+), 0 deletions(-)
>>>
>>> Applied, thanks.
>>>
>>> Ben, I hope this is OK with you.
>>
>> In fact, I don't think it's a good fix to fec-mac-address-not-set issue,
>> it's just a hack. This is the output from bootup log,
>>
>> Warning: FEC MAC addresses don't match:
>> Address in SROM is         75:6e:20:62:6f:6f
>> Address in environment is  00:01:02:04:05:06
>>
>> It will give one confused warning that the FEC MAC has been set in the
>> SROM, but actually, this the float value which induced by this patch.
>>
>> In fact, we need read the mac address from FUSE(IIM), all the MAC
>> address has burned into fuse after the chip has been shipped out.
>>
>> I will send out one patch to fix this issue soon.
>>
>>>
>>> Best regards,
>>>
>>> Wolfgang Denk
>>>
>>> --
>>> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
>>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
>>> There are three ways to get something  done:  do  it  yourself,  hire
>>> someone, or forbid your kids to do it.
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>