[U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence

Wolfgang Denk wd at denx.de
Tue Sep 7 21:00:16 CEST 2010


Dear Albert ARIBAUD,

In message <4C867741.6060906 at free.fr> you wrote:
> 
> I'm a bit lost at the logic of this last sentence. If errors are not 
> always represented as negative return values, and especially so in 
> U-boot, then what is the rationale for supporting a request for 
> specifically negative error return values, rather than positive, here? 

Even though ther eis lots of code that could need improvement, we
should not take such bad examples, but rather try to apply standard
techniques instead.

> Not that I mind much -- as I said, ide_init() does not mind, and that's 
> my reference -- and I'll happily put negative error codes in V3, but I 
> like to understand why people want things.

It's just a pretty common thing to do, and instead of doing the same
thing in many different ways it makes some sense to use a standard
way.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Absolute: Independent, irresponsible. An absolute monarchy is one  in
which  the  sovereign  does  as  he pleases so long as he pleases the
assassins. Not many absolute monarchies are left, most of them having
been replaced by limited monarchies, where the soverign's  power  for
evil (and for good) is greatly curtailed, and by republics, which are
governed by chance.                                  - Ambrose Bierce


More information about the U-Boot mailing list