[U-Boot] [PATCH 5/5] Allow tftp server to be different from bootp/dhcp server

[Wolfgang Denk]

Dear Simon Glass,

In message <1302642840-6958-5-git-send-email-sjg at chromium.org> you wrote:
> In many environments the DHCP server (which provides IP addresses) is not
> under control of the individual engineer. While it is required in order to
> connect to the corporate network, it doesn't provide useful information for
> booting. For example, it may be set up for PC imaging and provide a bootfile
> and tftp server for pxelinux.
> 
> To deal with this, this commit provides for a separate tftpserverip environment
> variable. If this is defined, then this IP address is used in preference
> to serverip. A new CONFIG_BOOTP_IGNORE_BOOTFILE option is provided to indicate
> that any bootfile name returned by the DHCP server is bogus and should be
> ignored.

Why don't you simply re-assing another value to "serverip" before
doing any TFTP transfers?

This can be done with trivial scripting, without any code changes.

> To use this feature, just setenv tftpserverip to the address of your TFTP
> server and define CONFIG_BOOTP_IGNORE_BOOTFILE in your board file.

Why don't you simply set the "autoload" environment variable to "no"?
This is the documented way to do exactly this.

Sorry, but I see no use for this patch.

NAK.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You could end up being oddly sad and full of a strange, diffuse  com-
passion  which would lead you to believe that it might be a good idea
to wipe out the whole human race and start again with amoebas.
                                 - Terry Pratchett, _Guards! Guards!_