[U-Boot] [PATCH] cfi_flash: Fix CONFIG_SYS_FLASH_AUTOPROTECT_LIST usage

Wolfgang Denk wd at denx.de
Wed Apr 13 21:50:40 CEST 2011


Dear Peter Tyser,

In message <1302713216-23363-1-git-send-email-ptyser at xes-inc.com> you wrote:
> Commit 6ee1416e8184b4d9ebe6087d396a60bcecf3551c (mtd, cfi: introduce
> void flash_protect_default(void)) introduced a bug which resulted in
> boards that define CONFIG_SYS_FLASH_AUTOPROTECT_LIST not compiling with
> the the following errors and warning:
>   ptyser at petert u-boot $ make -s xpedite520x
>   Configuring for xpedite520x board...
>   cfi_flash.c: In function 'flash_protect_default':
>   cfi_flash.c:2118: error: 'i' undeclared (first use in this function)
>   cfi_flash.c:2118: error: (Each undeclared identifier is reported only once
>   cfi_flash.c:2118: error: for each function it appears in.)
>   cfi_flash.c:2118: error: 'apl' undeclared (first use in this function)
>   cfi_flash.c:2118: error: invalid application of 'sizeof' to incomplete type 'struct apl_s'
>   cfi_flash.c: In function 'flash_init':
>   cfi_flash.c:2137: warning: unused variable 'apl'
> 
> Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
> Reported-by: Kumar Gala <galak at kernel.crashing.org>
> Cc: Heiko Schocher <hs at denx.de>
> ---
> Thanks for noticing this Kumar.
> 
>  drivers/mtd/cfi_flash.c |   14 ++++++++------
>  1 files changed, 8 insertions(+), 6 deletions(-)

Appled, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The shortest unit of time in the multiverse is the News York  Second,
defined  as  the  period  of  time between the traffic lights turning
green and the cab behind you honking.
                                - Terry Pratchett, _Lords and Ladies_


More information about the U-Boot mailing list