[U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

Macpaul Lin macpaul at gmail.com
Fri Apr 15 10:57:47 CEST 2011


Hi Mike,

2011/4/15 Mike Frysinger <vapier at gentoo.org>:
>> Do you mean the replacement with space to ident?
>>
>> According to the 2.6.38.1's checkpatch, it reported:
>> WARNING: please, no spaces at the start of a line
>
> this particular check has already been posted upstream as generally causing
> more harm than good.  but getting checkpatch fixed often feels glacial.

Thanks for your information, I didn't read that article before.
Could you provide the URL of related discussion that could be found in
the mailing list?

> up to Wolfgang how he feels about ifdef indentation
> -mike

Sure. I think we can discuss about it and then decides how to deal with it. :)
Just waiting for Wolfgang's opinion and see if the revised patch is
need to be send.

-- 
Best regards,
Macpaul Lin


More information about the U-Boot mailing list