[U-Boot] [PATCH] xilinx_emaclite.c ping-pong macro names

alain.peteut at space.unibe.ch alain.peteut at space.unibe.ch
Fri Apr 15 14:49:08 CEST 2011


Please find attached the checked patch. Sorry for the inconvenience.

Kind regards,
Alain

Quoting Wolfgang Denk <wd at denx.de>:

> Dear alain.peteut at space.unibe.ch,
>
> In message <20110415124815.1253591nkjx5al4f at mail.unibe.ch> you wrote:
>>
>> The macro name configuring  Ping/Pong didn't match. It has been
>> checked on a Spartan3e Starterkit.
>
> This should probably be part of the commit message.
>
>
> Your patch has a number of coding style issues: indentation not by
> TAB, trailing white space, etc.  Please fix, then verify by ruinning
> through checkpatch, and resubmit.
>
> Thanks.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Children are natural mimics who act like their parents despite  every
> effort to teach them good manners.
>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-xilinx_emaclite.c-Ping-Pong-fixes.patch
Type: text/x-diff
Size: 0 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110415/567d7583/attachment.patch 


More information about the U-Boot mailing list