[U-Boot] Policy for checkpatch usage?

[Detlev Zundel]

Hi Eric,

> On Thu, Apr 21, 2011 at 04:56:36PM +0200, Fabian Cenedese wrote:
>> Is that even possible? The cosmetic patch itself will be surrounded
>> by context lines which may fire up a warning. So these lines need
>> to be changed as well to satisy checkpatch. But this new patch
>> will again include several context lines... until you have to fix up the
>> whole file. Or did I misunderstand?
>
> What's wrong with (cosmetically) fixing all the files that a patch
> touches?  That way the project gets incremental cleanup of the code
> base as it evolves.

Of course such a cleanup would be nice indeed, but I assume that many
people do not want to go this extra mile - alas I do not want to require
it.

> (It would be easy to automate a check for whitespace-only patches to
> ease the job of the custodians.  Line-breaking and other style changes
> might still require eyeballing.)

Like this?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: is-whitespace-patch.sh
Type: text/x-sh
Size: 398 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110421/62542f99/attachment.sh 
-------------- next part --------------

Cheers
  Detlev

-- 
Question    : If you were redesigning UNIX, what would you do differently?
Ken Thompson: I'd spell creat with an e.
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de