[U-Boot] [PATCH 2/3] Fix a few gcc warnings.

Wolfgang Denk wd at denx.de
Tue Apr 26 00:29:06 CEST 2011


Dear Scott Wood,

In message <20110425162854.05500a06 at schlenkerla.am.freescale.net> you wrote:
>
> > I disagree. "printf(foo);" may be suboptimal but there are cases
> > where I do not want to see a warning about this. Consider for example
> > common/main.c:
> > 
> >  115 #  ifdef CONFIG_AUTOBOOT_PROMPT
> >  116         printf(CONFIG_AUTOBOOT_PROMPT);
> >  117 #  endif
> > 
> > Here we provide a way for a user-defined autoboot prompt message. Some
> > users may just want to provide a plain string - what's wrong with
> > that?  [Yes, there are other ways to implement this, but why make it
> > more complicated than necessary?]
> 
> It won't warn there, because it all happens in the preprocessor.

Why would it not warn if the user just does

	#define CONFIG_AUTOBOOT_PROMPT "my prompt:"

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How much net work could a network work, if a network could net work?


More information about the U-Boot mailing list