[U-Boot] [PATCH v2] arm/kirkwood: print speeds with cpu info.

Wolfgang Denk wd at denx.de
Mon Aug 1 14:53:00 CEST 2011


Dear Jason Cooper,

In message <1312160667-14248-1-git-send-email-u-boot at lakedaemon.net> you wrote:
> If CONFIG_DISPLAY_CPUINFO is enabled on kirkwood SoCs, this will print the
> speeds of the various components.
> 
> Signed-off-by: Jason Cooper <u-boot at lakedaemon.net>
> ---
> Changes since v1:
> 	- optimized macros to remove one-timers
> 	- reduced switch/case to if/else since it operates on one bit.
> 	- remove RFC
> 
>  arch/arm/cpu/arm926ejs/kirkwood/cpu.c    |   41 ++++++++++++++++++++++++++++++
>  arch/arm/include/asm/arch-kirkwood/cpu.h |    1 +
>  2 files changed, 42 insertions(+), 0 deletions(-)
...
> +	printf("CPU running @ %dMHz L2 running @ %dMHz\n",
> +		cpu_clk, l2_clk);
> +	printf("SysClock = %dMHz, TClock = %dMHz\n",
> +		sys_clk, t_clk / 1000000);

Please do NOT print such information as part of the regular,
unconditionally printed boot messages.  We want to keep thes
einformatiove, but otherwise as short as possible.

I recommend to use the "clock" command to print such information  then
the user is free to decide if he wants to see this, or not.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
panic: kernel trap (ignored)


More information about the U-Boot mailing list