[U-Boot] [PATCH v5 1/2] gpio: Add GPIO driver framework for Marvell SoCs

Ajay Bhargav ajay.bhargav at einfochips.com
Thu Aug 11 07:07:23 CEST 2011


----- "Lei Wen" <adrian.wenl at gmail.com> wrote:
> 
> You should remove these two define, or we would met build error as:
> cmd_gpio.c:20: error: expected identifier before numeric constant
> cmd_gpio.c: In function 'do_gpio':
> cmd_gpio.c:49: error: 'GPIO_CLEAR' undeclared (first use in this
> function)
> cmd_gpio.c:49: error: (Each undeclared identifier is reported only
> once
> cmd_gpio.c:49: error: for each function it appears in.)
> cmd_gpio.c:50: error: 'GPIO_TOGGLE' undeclared (first use in this
> function)
> 
> Except this, other looks good to me, and I have verify the reset of
> patch on mmp3 board.
> 
> Thanks,
> Lei
> 
Hi Lei,

Thank you so much for pointing out. I tested library by simply defining
MARVELL_GPIO, I forgot to test with CMD_GPIO.

I will change the names and resubmit. sorry for mistake.

Thanks & Regards,
Ajay Bhargav


More information about the U-Boot mailing list